[
https://issues.apache.org/jira/browse/GEODE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123741#comment-17123741
]
ASF GitHub Bot commented on GEODE-8119:
---------------------------------------
jujoramos commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-637520546
@mkevo
One thing I forgot to mention is that I ran the internal tests again and I
can see exactly the same failure messages as before:
```
Executing - validate offline-disk-store
--disk-dirs=/var/vcap/data/rundir/concUpgradeVVXHV/concUpgrade-0602-045131/vm_7_oldVersion2_disk_4,/var/vcap/data/rundir/concUpgradeVVXHV/concUpgrade-0602-045131/vm_7_oldVersion2_disk_3,/var/vcap/data/rundir/concUpgradeVVXHV/concUpgrade-0602-045131/vm_7_oldVersion2_disk_2,/var/vcap/data/rundir/concUpgradeVVXHV/concUpgrade-0602-045131/vm_7_oldVersion2_disk_1
--name=diskStore1
Standard error was:
Could not find:
"/BACKUPdiskStore1.if/BACKUPdiskStore1.if/BACKUPdiskStore1.if"
```
Also, and just for your reference, keep in mind that the `.if` file _**is
only stored**_ in the first `disk-dir` listed for the store itself, not for
everyone `disk-dir` configured for that particular `disk-store` (see
[here](https://geode.apache.org/docs/guide/112/managing/disk_storage/file_names_and_extensions.html)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Threads are not properly closed when offline disk-store commands are invoked
> ----------------------------------------------------------------------------
>
> Key: GEODE-8119
> URL: https://issues.apache.org/jira/browse/GEODE-8119
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
>
> Threads can be opened when you are online and offline, but close only when
> you are online. Once some offline command started thread it cannot be closed
> and after some time if there is a bigger number of this threads it can lead
> to OOM exception.
> Also the problem is that its validating only disk-dirs but not diskStore
> name. So thread can be created but there is no diskStore with that name and
> it will also hang.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
