[ 
https://issues.apache.org/jira/browse/GEODE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124113#comment-17124113
 ] 

ASF GitHub Bot commented on GEODE-7508:
---------------------------------------

pdxcodemonkey opened a new pull request #609:
URL: https://github.com/apache/geode-native/pull/609


   - Also stop copying them into the build tree as part of the build.  Tests 
now pick them up as needed from the source tree
   - Also a few keys were duplicated into the examples source tree so they 
would be part of the install, rather than using an install() command in 
CMakeLists.txt.  We do the right thing with these files now.
   
   @mreddington @dihardman @davebarnes97 @karensmolermiller 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clean up usage of keystore, truststore files
> --------------------------------------------
>
>                 Key: GEODE-7508
>                 URL: https://issues.apache.org/jira/browse/GEODE-7508
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Blake Bender
>            Priority: Major
>
> As a developer, I want to know where to find resource files I need for 
> writing/running a test.  I would also prefer not to have multiple copies of 
> these files in my source tree.  This is not the case for our SSL keys, and it 
> really needs to be cleaned up.
>  
> Acceptance criteria:
>  
> i. If I run `find . -name *.pem` or `find . -name *.jks` (or the Windows 
> equivalent) from the root of the native client source tree, I should only 
> find one copy of any particular file.  Ideally, I should only find each type 
> of file in a single directory, as well.  
> ii. After a clean build of the native client, there should be _no_ .pem or 
> .jks files in the build directory.  Several of the SSL tests were found to 
> have dependencies on these files in the build location, rather than the 
> source tree.
> iii. All code that refers to one of these files should refer to it via a 
> named constant/property in the Config class.  These are created by modifying 
> /clicache/integration-test2/Config.cs.in for C#, and 
> /cppcache/integration/framework/TestConfig.h & 
> /cppcache/integration/framework/TestConfig.cpp.in for C++.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to