[ https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125337#comment-17125337 ]
ASF GitHub Bot commented on GEODE-2484: --------------------------------------- codecov-commenter commented on pull request #591: URL: https://github.com/apache/geode-native/pull/591#issuecomment-638471186 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/591?src=pr&el=h1) Report > Merging [#591](https://codecov.io/gh/apache/geode-native/pull/591?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/ef435e18a842cdc7312ea522664b776bc654183d&el=desc) will **increase** coverage by `0.09%`. > The diff coverage is `72.09%`. [![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/591/graphs/tree.svg?width=650&height=150&src=pr&token=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/591?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #591 +/- ## =========================================== + Coverage 73.48% 73.58% +0.09% =========================================== Files 641 640 -1 Lines 50976 50940 -36 =========================================== + Hits 37460 37482 +22 + Misses 13516 13458 -58 ``` | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/591?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [cppcache/src/TcpSslConn.hpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjcFNzbENvbm4uaHBw) | `50.00% <ø> (ø)` | | | [cppcache/src/TcpSslConn.cpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjcFNzbENvbm4uY3Bw) | `68.81% <53.84%> (-0.75%)` | :arrow_down: | | [cppcache/src/Utils.cpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1V0aWxzLmNwcA==) | `62.80% <76.47%> (+1.20%)` | :arrow_up: | | [cppcache/src/RegionAttributes.cpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlZ2lvbkF0dHJpYnV0ZXMuY3Bw) | `31.76% <80.00%> (ø)` | | | [cppcache/src/CacheXmlParser.hpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NhY2hlWG1sUGFyc2VyLmhwcA==) | `66.66% <100.00%> (ø)` | | | [cppcache/src/Utils.hpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1V0aWxzLmhwcA==) | `80.95% <100.00%> (+0.95%)` | :arrow_up: | | [cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==) | `86.17% <0.00%> (-0.82%)` | :arrow_down: | | [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `75.00% <0.00%> (-0.63%)` | :arrow_down: | | [cppcache/src/ClientMetadata.cpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhLmNwcA==) | `66.04% <0.00%> (-0.62%)` | :arrow_down: | | [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `54.97% <0.00%> (-0.57%)` | :arrow_down: | | ... and [6 more](https://codecov.io/gh/apache/geode-native/pull/591/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/591?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/591?src=pr&el=footer). Last update [ef435e1...cb66d7b](https://codecov.io/gh/apache/geode-native/pull/591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE from native client dependencies > ------------------------------------------ > > Key: GEODE-2484 > URL: https://issues.apache.org/jira/browse/GEODE-2484 > Project: Geode > Issue Type: Task > Components: native client > Reporter: David Kimura > Priority: Major > Labels: pull-request-available > Fix For: 1.9.0 > > Time Spent: 11h 20m > Remaining Estimate: 0h > > Remove ACE from native client dependencies. > Replace ACE usage with C++11 and/or Boost 1.63+ -- This message was sent by Atlassian Jira (v8.3.4#803005)