[
https://issues.apache.org/jira/browse/GEODE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132651#comment-17132651
]
ASF GitHub Bot commented on GEODE-8099:
---------------------------------------
jchen21 commented on a change in pull request #5188:
URL: https://github.com/apache/geode/pull/5188#discussion_r438353291
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/BaseManagementService.java
##########
@@ -94,6 +94,13 @@ public static void
setManagementService(InternalCacheForClientAccess cache,
}
}
+ @VisibleForTesting
+ public static void clearManagementService(InternalCacheForClientAccess
cache) {
+ synchronized (instances) {
+ instances.remove(cache);
Review comment:
Looking at `BaseManagementService`, this is the only `instances.remove`
statement to remove an entry from the `HashMap`. Entries are put to the
`HashMap`, but never removed individually. There is `instances.clear`, but it
removes everything in the `HashMap`. This concern maybe outside the scope of
this JIRA ticket though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make ClusterConfiguration Service thread safe
> ---------------------------------------------
>
> Key: GEODE-8099
> URL: https://issues.apache.org/jira/browse/GEODE-8099
> Project: Geode
> Issue Type: Bug
> Components: configuration
> Reporter: Anilkumar Gingade
> Priority: Major
> Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> When multiple cluster configuration clients (multiple rest clients) connects
> and issue configuration commands, the cluster configuration should handle
> concurrent request and modify/save/execute the configuration definition in
> thread safe manner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
