[
https://issues.apache.org/jira/browse/GEODE-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145969#comment-17145969
]
ASF GitHub Bot commented on GEODE-8250:
---------------------------------------
jinmeiliao commented on a change in pull request #5309:
URL: https://github.com/apache/geode/pull/5309#discussion_r445930634
##########
File path:
geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java
##########
@@ -145,9 +145,7 @@ public GfshExecution execute(GfshScript gfshScript, File
workingDir) {
public GfshExecution execute(GfshScript gfshScript) {
try {
- File workingDir = new File(temporaryFolder.getRoot(),
gfshScript.getName());
- workingDir.mkdirs();
- return execute(gfshScript, workingDir);
+ return execute(gfshScript, temporaryFolder.getRoot());
Review comment:
so basically all scripts executed under the same gfshRule would use the
same gfsh working dir instead of each execution has its own. I think this is a
good change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve documentation for logging
> ---------------------------------
>
> Key: GEODE-8250
> URL: https://issues.apache.org/jira/browse/GEODE-8250
> Project: Geode
> Issue Type: Improvement
> Components: docs
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
> Labels: GeodeOperationAPI, docs, logging
> Fix For: 1.14.0
>
>
> The documentation pages for logging need some fixes, clarification, and
> examples. Specifically the docs need updating to cover the newer geode-log4j
> module and its custom appenders. Examples should include how to use custom
> logging config with optional usage of the latest version of Geode's custom
> appenders and pattern converters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
