[
https://issues.apache.org/jira/browse/GEODE-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149723#comment-17149723
]
ASF GitHub Bot commented on GEODE-8240:
---------------------------------------
Bill commented on pull request #5334:
URL: https://github.com/apache/geode/pull/5334#issuecomment-652678946
> I trust this backport is pretty similar to the GEODE-8240 fix on develop
and your PR checks and testing are good.
>
> I am curious what the implications are for users currently running Geode
1.12.0. Should we advise that they upgrade to 1.12.1 to get this fix before
attempting to upgrade to 1.13.0?
This fix will be ported to `support/1.13` next. So 1.12.x users will be able
to upgrade to the soon-to-be-released 1.13.0 version directly.
>
> What about upgrades from 1.11.0 to 1.12.0 or 1.11.0 to 1.12.1?
The bug exists in the 1.12 line before this PR. I think this PR will go into
a 1.12.1 or 1.12.2?
If that's right, then a 1.11.0 to 1.12.0 upgrade will see the bug, and a
1.11.0 to 1.12.1 (or whatever release this PR goes into) will not see the bug.
Incidentally, I don't really know what versions of 1.12 actually exist after
1.12.0. I see a bunch of four-part version numbers here:
<img width="149" alt="image"
src="https://user-images.githubusercontent.com/4002/86296758-70d60800-bbae-11ea-96e1-702b5cf75bcc.png";>
I don't understand those four-part version numbers.
But I can say that a 1.11.x upgrade to a 1.12.x version that has this fix,
will work and the bug will be gone.
> In general does this bug only affect upgrades between minors, or between
patch versions too?
My understanding is that Geode usually does not change `Version.CURRENT`
between patch releases. On the other hand, I think I have heard that it has
been done at least once.
If you upgrade from one patch version to another patch version in the same
line and `Version.CURRENT` doesn't change then you won't see this bug.
If you upgrade from one patch version to another patch version in the same
line and `Version.CURRENT` _does_ change then you _will_ see this bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> View has old locator version number after rolling upgrade
> ---------------------------------------------------------
>
> Key: GEODE-8240
> URL: https://issues.apache.org/jira/browse/GEODE-8240
> Project: Geode
> Issue Type: Bug
> Components: client/server, membership
> Reporter: Ernest Burghardt
> Assignee: Bill Burcham
> Priority: Major
>
> as shown in [https://github.com/apache/geode/pull/5224]
> locator upgrade from version 1.12.0 doesn't seem to occur
> {{testRollServersOnPartitionedRegion_dataserializable}} failure results:
> Expecting:
> <"Member Count : 3
> Name | Id
> ---- |
> -------------------------------------------------------------------------------
> vm2 | 127.0.0.1(vm2:35019:locator)<ec><v17>:41000(version:GEODE 1.12.0)
> [Coordinator]
> vm0 | 10.0.0.111(vm0:35025)<v27>:41001
> vm1 | 10.0.0.111(vm1:35030)<v29>:41002
> ">
> not to contain:
> <"1.12.0">
> This problem was introduced in 1.12.0 and is present in all lines derived
> from that one, including 9.10, 1.13, and current develop/1.14
> What's actually happening is that the locator _is_ upgraded to a newer
> version. It joins with an older coordinator (that's running e.g. 1.12.0) and
> that coordinator produces a view showing the new locator/member as running
> the same version, in this case 1.12.0, as the coordinator.
> Eventually, all locators will be upgraded. But the view carries the incorrect
> version indication.
> The root cause seems to be that when {{GMSMemberData.setVersionObject(short
> versionOrdinal)}} sees a version ordinal that is unknown, i.e. a version
> ordinal corresponding to a new line of development: 1.13, 1.14, … that method
> throws away that version ordinal and replaces it with the one for the 1.12
> line.
> Since the current {{support/1.13}} and {{develop}} branches have the bug
> upgrading a current 1.13 to 1.14 or a current development/1.14 to 1.15 would
> exhibit the same behavior (locator apparently stuck at the older version in
> the view.)
> Ramifications of this incorrect version indication in the view are TBD.
> Whether or not this situation resolves itself after _another_ round of
> restarts is TBD.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
![https://user-images.githubusercontent.com/4002/86296758-70d60800-bbae-11ea-96e1-702b5cf75bcc.png"](https://user-images.githubusercontent.com/4002/86296758-70d60800-bbae-11ea-96e1-702b5cf75bcc.png"){kind=link}