[
https://issues.apache.org/jira/browse/GEODE-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164604#comment-17164604
]
ASF GitHub Bot commented on GEODE-8333:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5349:
URL: https://github.com/apache/geode/pull/5349#discussion_r460243756
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -113,17 +114,19 @@ public ChannelFuture writeToChannel(RedisResponse
response) {
@Override
public void channelRead(ChannelHandlerContext ctx, Object msg) throws
Exception {
Command command = (Command) msg;
- try {
- if (logger.isDebugEnabled()) {
- logger.debug("Executing Redis command: {}", command);
+ command.setChannelHandlerContext(ctx);
Review comment:
Yes, and since isEmpty and isAsync are only used once I ended up
changing it to this:
```
synchronized (commandQueue) {
if (!commandQueue.isEmpty()) {
commandQueue.offer(command);
return;
}
if (command.getCommandType().isAsync()) {
commandQueue.offer(command);
startAsyncCommandExecution(command);
return;
}
executeCommand(command);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix PUBSUB hang
> ---------------
>
> Key: GEODE-8333
> URL: https://issues.apache.org/jira/browse/GEODE-8333
> Project: Geode
> Issue Type: Bug
> Components: redis
> Reporter: Sarah Abbey
> Priority: Major
> Labels: pull-request-available
>
> PUBSUB hangs with concurrent publishers and subscribers on multiple servers
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
