[
https://issues.apache.org/jira/browse/GEODE-8102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169223#comment-17169223
]
ASF GitHub Bot commented on GEODE-8102:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #630:
URL: https://github.com/apache/geode-native/pull/630#discussion_r463914946
##########
File path: clicache/src/CMakeLists.txt
##########
@@ -23,7 +23,7 @@
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/impl/AssemblyInfo.cpp.in ${CMAKE_CURR
list(APPEND CONFIGURE_IN_FILES
${CMAKE_CURRENT_SOURCE_DIR}/impl/AssemblyInfo.cpp.in)
list(APPEND CONFIGURE_OUT_FILES
${CMAKE_CURRENT_BINARY_DIR}/impl/AssemblyInfo.cpp)
-add_library(${PROJECT_NAME} SHARED
+add_library(Apache.Geode SHARED
Review comment:
Most of the IDE's that integrate with CMake don't resolve the target
names correctly if they are variables. It's also not necessary that all targets
be unique projects in CMake. It was a bad pattern that was used in the early
days in CMake and in Geode Native (my bad).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Link and load OpenSSL library directly
> --------------------------------------
>
> Key: GEODE-8102
> URL: https://issues.apache.org/jira/browse/GEODE-8102
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> Lazy load the OpenSSL library directly, through ACE_SSL, into the
> apache-geode library. Currently we lazy load cryptoImpl, which immediately
> loads OpenSSL. The original intent was to avoid having an immediate
> dependency on OpenSSL at a time when its availability was questionable. On
> unix like systems OpenSSL is almost always available since so many other
> components in the OS depend on it. This immediate load dependency will have
> little to no effect on those systems. On some unix like systems the
> experience will improve by not having a runtime dependency on an intermediate
> library, cryptoImpl, that may need special treatments, like LD_LIBRARY_PATH
> or RPATH changes. On Windows, where OpenSSL is an anomaly we can use MSVC's
> lazy loading feature to only load OpenSSL if SSL/TLS is configured. This
> significantly improves the experience on Windows with regards to the location
> of cryptoImpl when using .NET.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
