[
https://issues.apache.org/jira/browse/GEODE-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171132#comment-17171132
]
ASF GitHub Bot commented on GEODE-6950:
---------------------------------------
bschuchardt opened a new pull request #5422:
URL: https://github.com/apache/geode/pull/5422
The ticket had a suggested fix for the locator's hot loop and I've
implemented that. I modified PrimaryHandler to make the issue testable and
added a couple of other tests for registered and fallback request handlers.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Locator can't start if a lot of clients already started
> -------------------------------------------------------
>
> Key: GEODE-6950
> URL: https://issues.apache.org/jira/browse/GEODE-6950
> Project: Geode
> Issue Type: Bug
> Components: core, membership
> Affects Versions: 1.7.0, 1.8.0, 1.9.0, 1.10.0, 1.11.0, 1.12.0
> Reporter: Eugene Nedzvetsky
> Assignee: Bruce J Schuchardt
> Priority: Major
> Attachments: 1.log
>
>
> Locator can't start if a few hundred clients already started.
> Steps to reproduce:
> 1. Start Locator
> 2. Start 300 Geode clients
> 3. Stop Locator
> 4. Start Locator again
> Observe 100% CPU load and after some time Locator app crashes with timeout
> exceptions in the log.
> The problem is in the method
> org.apache.geode.distributed.internal.InternalLocator.PrimaryHandler#processRequest
> handlerMapping doesn't have handlers for LocatorListRequest and
> ClientConnectionRequest requests on Locator startup and in this case work
> code part with condition 'if(giveup == 0)'(InternalLocator:1185)
> Pause Thread.sleep(1000) works only on the first iteration and after that
> giveup>0 and CPU just spends resources on cycle execution without any pauses.
> Call Thread.sleep(1000) should be after if(giveup>0) condition block. It
> will be called on each iteration in this case.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
