Bruce J Schuchardt created GEODE-8407:
-----------------------------------------

             Summary: MergeLogFiles fails to include files with the same name 
but in different directories
                 Key: GEODE-8407
                 URL: https://issues.apache.org/jira/browse/GEODE-8407
             Project: Geode
          Issue Type: Bug
          Components: tools
            Reporter: Bruce J Schuchardt


The default setting for MergeLogFiles is dirCount=0, meaning each line of the 
merge has the name of the corresponding log file but not its parent directory.

I tried merging a bunch of files named _system.log_ in different directories 
and found that, though all of the files were listed in the header only one of 
them was in the merged output.

If I set a dirCount of 1 then it works okay.

I think the flaw is in this line:
{code:java}
logFiles.put(logFileName, new FileInputStream(file));
{code}
 This is after the dirCount has been applied.  In my case each logFileName is 
going to be _system.log_ and each will overwrite whatever's already in the map, 
leaving only one file.

The full path name of each file should be used as a key in this map and the 
display name with dirCount applied needs to be held in this map in some other 
way.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to