[
https://issues.apache.org/jira/browse/GEODE-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171794#comment-17171794
]
ASF GitHub Bot commented on GEODE-8406:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5427:
URL: https://github.com/apache/geode/pull/5427#discussion_r466033207
##########
File path: ci/scripts/execute_tests.sh
##########
@@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then
exit 1
fi
+. ${SCRIPTDIR}/short_circuit_pr_tasks.sh
+cd geode
+ is_source_from_pr_testable "ci" "dev-tools" "etc" "geode-book" "geode-docs"
|| exit 0
Review comment:
I have little skin in this game but if it doesn't matter than I would
make it simple but if its not going to change over time then its probably fine
as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> enable early-return for CI only changes in Geode Concourse
> ----------------------------------------------------------
>
> Key: GEODE-8406
> URL: https://issues.apache.org/jira/browse/GEODE-8406
> Project: Geode
> Issue Type: Improvement
> Components: ci
> Reporter: Robert Houghton
> Priority: Major
> Labels: pull-request-available
>
> The Geode Concourse PR pipeline pulls the _ci_ scripts from upstream, not the
> code under test. Ergo, CI changes are untestable by the main CI itself, and
> running the PR jobs is useless, and costly.
> GitHub does not allow granular control of what directories require a _status_
> to allow merging, so our solution is to short circuit the work for CI-only
> PRs, allowing the status to be set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
