[
https://issues.apache.org/jira/browse/GEODE-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175112#comment-17175112
]
ASF GitHub Bot commented on GEODE-8417:
---------------------------------------
dschneider-pivotal opened a new pull request #5441:
URL: https://github.com/apache/geode/pull/5441
The fix for GEODE-8393 seems to have caused both GEODE-8417 and GEODE-8418.
This revert should fix those new issues.
This reverts commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CI failure:
> SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer
> fails with a timeout
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8417
> URL: https://issues.apache.org/jira/browse/GEODE-8417
> Project: Geode
> Issue Type: Bug
> Components: redis
> Reporter: Bruce J Schuchardt
> Priority: Major
>
> This test failed in a CI run:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/402#L5f20d92c:648]
>
> {noformat}
> org.apache.geode.redis.session.SessionExpirationDUnitTest >
> sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer FAILED
> 13:20:39 org.awaitility.core.ConditionTimeoutException: Condition with
> lambda expression in
> org.apache.geode.redis.session.SessionExpirationDUnitTest that uses
> java.lang.String was not fulfilled within 10 seconds.
> 13:20:39 at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> 13:20:39 at
> org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
> 13:20:39 at
> org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
> 13:20:39 at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> 13:20:39 at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
> 13:20:39 at
> org.apache.geode.redis.session.SessionExpirationDUnitTest.waitForTheSessionToExpire(SessionExpirationDUnitTest.java:113)
> 13:20:39 at
> org.apache.geode.redis.session.SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer(SessionExpirationDUnitTest.java:93)
> 13:20:39
> 13:20:39 Caused by:
> 13:20:39 redis.clients.jedis.exceptions.JedisConnectionException:
> java.net.SocketException: Broken pipe (Write failed)
> 13:20:39 at
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:109)
> 13:20:39 at
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:89)
> 13:20:39 at
> redis.clients.jedis.Connection.sendCommand(Connection.java:126)
> 13:20:39 at
> redis.clients.jedis.BinaryClient.ttl(BinaryClient.java:186)
> 13:20:39 at redis.clients.jedis.Client.ttl(Client.java:114)
> 13:20:39 at redis.clients.jedis.Jedis.ttl(Jedis.java:399)
> 13:20:39 at
> org.apache.geode.redis.session.SessionExpirationDUnitTest.lambda$waitForTheSessionToExpire$0(SessionExpirationDUnitTest.java:114)
> 13:20:39
> 13:20:39 Caused by:
> 13:20:39 java.net.SocketException: Broken pipe (Write failed)
> 13:20:39 at java.net.SocketOutputStream.socketWrite0(Native
> Method)
> 13:20:39 at
> java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:110)
> 13:20:39 at
> java.net.SocketOutputStream.write(SocketOutputStream.java:150)
> 13:20:39 at
> redis.clients.jedis.util.RedisOutputStream.flushBuffer(RedisOutputStream.java:52)
> 13:20:39 at
> redis.clients.jedis.util.RedisOutputStream.write(RedisOutputStream.java:59)
> 13:20:39 at
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:95)
> 13:20:39 ... 6 more
> 13:20:39 {noformat}
>
> I bisected and found it started failing here:
> {noformat}
> commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed
> Author: Darrel Schneider <[email protected]>
> Date: Mon Aug 10 12:50:31 2020 -0700
> GEODE-8393: change memberDeparted to disconnect the connection (#5431)
> * server now disconnects connection if memberDeparted
> Co-authored-by: john Hutchison <[email protected]>
> {noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
