[
https://issues.apache.org/jira/browse/GEODE-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182192#comment-17182192
]
ASF GitHub Bot commented on GEODE-8435:
---------------------------------------
onichols-pivotal commented on a change in pull request #5462:
URL: https://github.com/apache/geode/pull/5462#discussion_r475020784
##########
File path:
geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandTest.java
##########
@@ -362,28 +362,40 @@ public void resolveSslProperties() {
}
@Test
- public void connectToManagerWithDifferentMajorVersion() {
+ public void connectToManagerWithOlderMajorVersionAllowed() {
when(gfsh.getVersion()).thenReturn("2.2");
- when(operationInvoker.getRemoteVersion()).thenReturn("1.2");
+ when(operationInvoker.getRemoteVersion()).thenReturn("1.10");
+ when(gfsh.getGeodeSerializationVersion()).thenReturn("2.2");
+
when(operationInvoker.getRemoteGeodeSerializationVersion()).thenReturn("1.10");
when(operationInvoker.isConnected()).thenReturn(true);
+
Review comment:
some books on this subject advise against the temptation to factor out
"duplicated" code in unit tests. you could argue, perhaps, that we don't need
as many of the mock-base tests now that the shouldConnect logic is factored out
and tested separately...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> restore gfsh ability to connect if serialization versions match regardless of
> product version
> ---------------------------------------------------------------------------------------------
>
> Key: GEODE-8435
> URL: https://issues.apache.org/jira/browse/GEODE-8435
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Affects Versions: 1.12.1, 1.13.0, 1.14.0
> Reporter: Owen Nichols
> Assignee: Owen Nichols
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> This used to work but was broken recently by changes for GEODE-8331.
> Although this does not impact Geode releases, it causes quite a headache for
> developers that don't typically pass a product version in their gradle build
> command.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
