[
https://issues.apache.org/jira/browse/GEODE-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182907#comment-17182907
]
ASF GitHub Bot commented on GEODE-8441:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #639:
URL: https://github.com/apache/geode-native/pull/639#discussion_r475313465
##########
File path: clicache/src/CacheFactory.cpp
##########
@@ -70,14 +71,12 @@ namespace Apache
pdxReadSerialized = nativeCache->getPdxReadSerialized();
Log::SetLogLevel(static_cast<LogLevel>(native::Log::logLevel( )));
- native::createAppDomainContext =
&Apache::Geode::Client::createAppDomainContext;
-
DistributedSystem::ManagedPostConnect(cache);
DistributedSystem::registerCliCallback();
auto&& cacheImpl =
CacheRegionHelper::getCacheImpl(nativeCache.get());
cacheImpl->getSerializationRegistry()->setPdxTypeHandler(new
ManagedPdxTypeHandler());
-
cacheImpl->getSerializationRegistry()->setDataSerializableHandler(new
ManagedDataSerializableHandler());
+
cacheImpl->getSerializationRegistry()->setDataSerializableHandler(new
ManagedDataSerializableHandler());
Review comment:
Looks like formatting got out of wack with your Visual Studio. Can you
back out the change on this lineZ or better yet make the indent match the rest
of the file:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Can't pass GCHandle across AppDomains in Manage Connections Thread
> ------------------------------------------------------------------
>
> Key: GEODE-8441
> URL: https://issues.apache.org/jira/browse/GEODE-8441
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Martell
> Assignee: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> When running Asp.Net web applications, this exception is thrown by the thread
> named "NC MC Thread", which is the Manage Connections thread.
> The exception always comes in the above background thread that tries to
> maintain the minimum number of connections in the pool (20 is the default).
> The “Cannot pass a GCHandle across AppDomains” exception is thrown by the
> .NET runtime on that thread and is subsequently caught by
> TcrEndpoint::createNewConnection, so as to not crash the user application.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
