[
https://issues.apache.org/jira/browse/GEODE-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205087#comment-17205087
]
ASF GitHub Bot commented on GEODE-8550:
---------------------------------------
demery-pivotal commented on a change in pull request #5570:
URL: https://github.com/apache/geode/pull/5570#discussion_r497840452
##########
File path:
geode-junit/src/main/java/org/apache/geode/test/junit/rules/CloseableReference.java
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.test.junit.rules;
+
+import static org.apache.geode.util.internal.UncheckedUtils.uncheckedCast;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+
+import
org.apache.geode.test.junit.rules.serializable.SerializableExternalResource;
+
+/**
+ * JUnit Rule that provides automated tearDown for an atomic reference. If the
referenced value is
+ * an {@code AutoCloseable} or {@code Closeable} then it will be auto-closed
and set to null during
+ * tear down.
+ *
+ * <p>
+ * If the referenced value is not an {@code AutoCloseable} or {@code
Closeable}, the
+ * {@code CloseableReference} will use reflection to invoke any method named
{@code close} or
+ * {@code disconnect} regardless of what interfaces are implemented.
Review comment:
Also: stop()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Integration tests need a version of DistributedReference
> --------------------------------------------------------
>
> Key: GEODE-8550
> URL: https://issues.apache.org/jira/browse/GEODE-8550
> Project: Geode
> Issue Type: Wish
> Components: tests
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
> Labels: pull-request-available
>
> Integration tests need a version of DistributedReference. This will allow
> both integration and distributed tests to follow a similar approach for
> closable resources.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
