[
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205818#comment-17205818
]
ASF GitHub Bot commented on GEODE-8566:
---------------------------------------
sabbey37 commented on a change in pull request #5584:
URL: https://github.com/apache/geode/pull/5584#discussion_r498501625
##########
File path:
geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/key/RenameNativeRedisAcceptanceTest.java
##########
@@ -14,30 +14,25 @@
*/
package org.apache.geode.redis.internal.executor.key;
-import java.util.Random;
-
-import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
-import redis.clients.jedis.Jedis;
import org.apache.geode.NativeRedisTestRule;
-public class RenameNativeRedisAcceptanceTest extends RenameIntegrationTest {
+public class RenameNativeRedisAcceptanceTest extends
AbstractRenameIntegrationTest {
+
@ClassRule
public static NativeRedisTestRule redis = new NativeRedisTestRule();
- @BeforeClass
- public static void setUp() {
- rand = new Random();
- jedis = new Jedis("localhost", redis.getPort(), 10000000);
- jedis2 = new Jedis("localhost", redis.getPort(), 10000000);
- jedis3 = new Jedis("localhost", redis.getPort(), 10000000);
+ @Override
+ public int getPort() {
+ return redis.getPort();
}
@Override
@Test
@Ignore("native redis does implement renamenx")
public void renamenxIsUnimplemented() {}
+
Review comment:
Should we move this test out of the `AbstractRenameIntegrationTest` file
and into `RenameIntegrationTest` file like the `leakedSubscriptions` test
(which is just in the `SubscriptionsIntegrationTest` file)? Not sure which is
better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis native tests should not also stand up a Geode server
> ----------------------------------------------------------
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
> Issue Type: Test
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> Our native acceptance tests currently extend from the integration tests and
> both classes have a {{@ClassRule}} that results in both a native (container)
> instance and a Geode instance starting up. Mostly not a problem except for
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
