[
https://issues.apache.org/jira/browse/GEODE-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209785#comment-17209785
]
ASF GitHub Bot commented on GEODE-8580:
---------------------------------------
codecov-io commented on pull request #670:
URL: https://github.com/apache/geode-native/pull/670#issuecomment-705137350
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`develop@3ae0f32`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #670 +/- ##
==========================================
Coverage ? 74.26%
==========================================
Files ? 644
Lines ? 51131
Branches ? 0
==========================================
Hits ? 37971
Misses ? 13160
Partials ? 0
```
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=footer).
Last update
[3ae0f32...4b85e17](https://codecov.io/gh/apache/geode-native/pull/670?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improper use of throw in new C++ test framework
> -----------------------------------------------
>
> Key: GEODE-8580
> URL: https://issues.apache.org/jira/browse/GEODE-8580
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Martell
> Assignee: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> The new C++ test framework (cppcache/integration/framework) throws pointers
> to exceptions. This is never a good idea.
> [https://stackoverflow.com/questions/10948316/throw-new-stdexception-vs-throw-stdexception]
> Although you can catch pointers, it's not recommended practice.
> Note: The particular error I ran into was in GfshExecute::execute, where
> throw new GfshExecuteException("gfsh error", exit_code);
> was being used. This requires gtest to use:
> EXPECT_THROW(gfsh.query(query_stmt).execute(), GfshExecuteException*);
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
