[
https://issues.apache.org/jira/browse/GEODE-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211499#comment-17211499
]
ASF GitHub Bot commented on GEODE-8596:
---------------------------------------
moleske opened a new pull request #672:
URL: https://github.com/apache/geode-native/pull/672
Authored-by: M. Oleske <[email protected]>
Here's some flaky CI passes in
[Windows](https://github.com/moleske/geode-native/actions/runs/298200790),
[Ubuntu](https://github.com/moleske/geode-native/actions/runs/298200789), and
[Mac ](https://github.com/moleske/geode-native/actions/runs/298200788)for
showing it is working.
The `do...while` change in `fw_dunit.hpp` is because I got angry at some
unneeded semicolons in one of the files so I went ahead and wrapped the macro.
If folks don't like it I guess I can revert it and be sad about it on my own.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Enforce No Old Style Cast as Error
> ----------------------------------
>
> Key: GEODE-8596
> URL: https://issues.apache.org/jira/browse/GEODE-8596
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
>
> Given I compile the code without exempting no-old-style-cast
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
