[
https://issues.apache.org/jira/browse/GEODE-8663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223123#comment-17223123
]
ASF GitHub Bot commented on GEODE-8663:
---------------------------------------
jhutchison commented on a change in pull request #5678:
URL: https://github.com/apache/geode/pull/5678#discussion_r514480604
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java
##########
@@ -171,13 +180,92 @@ public void endCommand(RedisCommandType command, long
start) {
}
public void addClient() {
+ connectionsReceived.incrementAndGet();
+ connectedClients.incrementAndGet();
stats.incLong(clientId, 1);
}
public void removeClient() {
+ connectedClients.decrementAndGet();
stats.incLong(clientId, -1);
}
+ private final AtomicLong commandsProcessed = new AtomicLong();
+ private final AtomicLong opsPerSecond = new AtomicLong();
+ private final AtomicLong networkBytesRead = new AtomicLong();
+ private volatile double networkKilobytesReadPerSecond;
+ private final AtomicLong connectionsReceived = new AtomicLong();
+ private final AtomicLong connectedClients = new AtomicLong();
+ private final AtomicLong expirations = new AtomicLong();
+ private final AtomicLong keyspaceHits = new AtomicLong();
+ private final AtomicLong keyspaceMisses = new AtomicLong();
Review comment:
will add
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> update Redis Info command To include additional statistics
> ----------------------------------------------------------
>
> Key: GEODE-8663
> URL: https://issues.apache.org/jira/browse/GEODE-8663
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: John Hutchison
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
