[
https://issues.apache.org/jira/browse/GEODE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226246#comment-17226246
]
ASF GitHub Bot commented on GEODE-8683:
---------------------------------------
albertogpz opened a new pull request #5701:
URL: https://github.com/apache/geode/pull/5701
The maximum-time-between-pings set when creating a gateway receiver
was not honored because the ClientHealthMonitor, that is the singleton
class monitoring all clients, supported just one value for maximum
time between pings for all clients. This value is set
when the server in which the receiver is running is started
and when the gateway receiver provides a different value
it is ignored.
With this fix, it is allowed to have different values
for maximum-time-between-clients for different clients.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> maximum-time-between-pings parameter in GatewayReceiver creation does not
> have any effect
> -----------------------------------------------------------------------------------------
>
> Key: GEODE-8683
> URL: https://issues.apache.org/jira/browse/GEODE-8683
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
>
> The maximum-time-between-pings parameter than can be set at gateway sender
> creation has no effect, i.e. the value used as maximum time between pings for
> gateway sender connections to the gateway receiver is either the default
> value (60000) or the one set on the server where the receiver is running.
> The reason is that the ClientHealthMonitor is a server-side singleton that
> monitors the health of all clients. The value set for this parameter in the
> ClientHealthMonitor is first set when the server is started and the first
> Acceptor is created.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
