[
https://issues.apache.org/jira/browse/GEODE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245538#comment-17245538
]
ASF GitHub Bot commented on GEODE-8769:
---------------------------------------
ringles opened a new pull request #5818:
URL: https://github.com/apache/geode/pull/5818
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ X] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ X] Is your initial contribution a single, squashed commit?
- [ X] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
This helps to mitigate the issue but does not completely solve it. The
problem happens when multiple threads are opening multiple Redis connections,
and the statistics are reset. Depending on the timing of the connection opening
and closing, the operations can interleave and result in an inconsistent state
for the statistics. The stats will be "eventually correct" unless their values
are explicitly reset at an unlucky time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CI Failure: org.apache.geode.redis.internal.RedisStatsIntegrationTest >
> clientsStat_withConnectAndClose_isCorrect FAILED
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8769
> URL: https://issues.apache.org/jira/browse/GEODE-8769
> Project: Geode
> Issue Type: Bug
> Components: redis
> Affects Versions: 1.14.0
> Reporter: Raymond Ingles
> Assignee: Raymond Ingles
> Priority: Minor
> Fix For: 1.14.0
>
>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsIntegrationTestOpenJDK8/builds/592
> org.apache.geode.redis.internal.RedisStatsIntegrationTest >
> clientsStat_withConnectAndClose_isCorrect FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.redis.internal.RedisStatsIntegrationTest expected:<[0]L> but
> was:<[-2]L> within 2 seconds.
> at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> at
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
> at
> org.apache.geode.redis.internal.RedisStatsIntegrationTest.clientsStat_withConnectAndClose_isCorrect(RedisStatsIntegrationTest.java:484)
> Caused by:
> org.junit.ComparisonFailure: expected:<[0]L> but was:<[-2]L>
> at sun.reflect.GeneratedConstructorAccessor31.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.RedisStatsIntegrationTest.lambda$clientsStat_withConnectAndClose_isCorrect$4(RedisStatsIntegrationTest.java:484)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
