[
https://issues.apache.org/jira/browse/GEODE-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268940#comment-17268940
]
ASF GitHub Bot commented on GEODE-8837:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5905:
URL: https://github.com/apache/geode/pull/5905#discussion_r561404810
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceProvider.java
##########
@@ -59,7 +60,7 @@ public static CqService create(InternalCache cache) {
return new MissingCqService();
}
- return factory.create(cache);
+ return factory.create(cache, CommandInitializer.getDefaultInstance());
Review comment:
Not without a much deeper refactoring. We will need a way to connect two
very distant components and that is just out of scope for what I want to get
done now. So it's no worse than it was. It should discourage continued abuse.
It is now testable. So I see a net positive here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Establish GFE_81 as the oldest supported client version.
> --------------------------------------------------------
>
> Key: GEODE-8837
> URL: https://issues.apache.org/jira/browse/GEODE-8837
> Project: Geode
> Issue Type: Improvement
> Components: client/server, core, cq, functions
> Reporter: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> Remove support for versions older than GFE_81 in backwards compatibility
> checks and command tables.
> Remove the unused and unreleased GFE_82 ordinal for consistency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
