[
https://issues.apache.org/jira/browse/GEODE-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269734#comment-17269734
]
ASF GitHub Bot commented on GEODE-8837:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5905:
URL: https://github.com/apache/geode/pull/5905#discussion_r562286534
##########
File path:
geode-serialization/src/test/java/org/apache/geode/internal/serialization/KnownVersionJUnitTest.java
##########
@@ -44,18 +39,21 @@ public void testKnownVersionClass() throws Exception {
compare(KnownVersion.GEODE_1_10_0, KnownVersion.GEODE_1_9_0);
compare(KnownVersion.GEODE_1_11_0, KnownVersion.GEODE_1_10_0);
compare(KnownVersion.GEODE_1_12_0, KnownVersion.GEODE_1_11_0);
- compare(KnownVersion.GEODE_1_13_0, KnownVersion.GEODE_1_12_0);
- compare(KnownVersion.GEODE_1_14_0, KnownVersion.GEODE_1_13_0);
+ compare(KnownVersion.GEODE_1_12_1, KnownVersion.GEODE_1_12_0);
+ compare(KnownVersion.GEODE_1_13_0, KnownVersion.GEODE_1_12_1);
+ compare(KnownVersion.GEODE_1_13_1, KnownVersion.GEODE_1_13_0);
+ compare(KnownVersion.GEODE_1_14_0, KnownVersion.GEODE_1_13_1);
}
private void compare(KnownVersion later, KnownVersion earlier) {
assertTrue(later.compareTo(earlier) > 0);
- assertTrue(later.equals(later));
- assertTrue(later.compareTo(later) == 0);
+ assertEquals(later, later);
+ // noinspection EqualsWithItself for testing
+ assertEquals(0, later.compareTo(later));
assertTrue(earlier.compareTo(later) < 0);
assertTrue(later.compareTo(Versioning.getVersion(earlier.ordinal())) > 0);
- assertTrue(later.compareTo(Versioning.getVersion(later.ordinal())) == 0);
+ assertEquals(0, later.compareTo(Versioning.getVersion(later.ordinal())));
assertTrue(earlier.compareTo(Versioning.getVersion(later.ordinal())) < 0);
Review comment:
Static analyzer didn't pick that one up... Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Establish GFE_81 as the oldest supported client version.
> --------------------------------------------------------
>
> Key: GEODE-8837
> URL: https://issues.apache.org/jira/browse/GEODE-8837
> Project: Geode
> Issue Type: Improvement
> Components: client/server, core, cq, functions
> Reporter: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> Remove support for versions older than GFE_81 in backwards compatibility
> checks and command tables.
> Remove the unused and unreleased GFE_82 ordinal for consistency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
