[
https://issues.apache.org/jira/browse/GEODE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273023#comment-17273023
]
ASF GitHub Bot commented on GEODE-8867:
---------------------------------------
nonbinaryprogrammer commented on a change in pull request #5955:
URL: https://github.com/apache/geode/pull/5955#discussion_r565492510
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/hash/AbstractHashesIntegrationTest.java
##########
@@ -540,6 +540,22 @@ public void testHLen() {
}
+ @Test
+ public void testHLenErrorMessage_givenIncorrectDataType() {
+ jedis.set("farm", "chicken");
+ assertThatThrownBy(() -> jedis.hlen("farm"))
+ .isInstanceOf(JedisDataException.class)
+ .hasMessageContaining("WRONGTYPE Operation against a key holding the
wrong kind of value");
+ }
+
+ @Test
+ public void testHLen_givenWrongNumberOfArguments() {
+ assertThatThrownBy(() -> jedis.sendCommand(Protocol.Command.HLEN))
+ .hasMessageContaining("wrong number of arguments");
+ assertThatThrownBy(() -> jedis.sendCommand(Protocol.Command.HLEN, "1",
"2"))
+ .hasMessageContaining("wrong number of arguments");
Review comment:
thanks! I thought I had changed them all in a previous commit but that
was on a different branch. good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unit/Integration/multi-node concurrency (Dunit) tests for **HLEN** command
> --------------------------------------------------------------------------
>
> Key: GEODE-8867
> URL: https://issues.apache.org/jira/browse/GEODE-8867
> Project: Geode
> Issue Type: Test
> Components: redis
> Reporter: Helena Bales
> Assignee: Helena Bales
> Priority: Major
> Labels: pull-request-available
>
> Write unit and integration tests.
> Write dunit tests, to launch multi-node clusters, which test multiple
> concurrent clients accessing different servers for the following command:
> HLEN
> A.C.
> Tests are passing, and README/redis_api_for_geode.html.md.erb updated to
> make command "supported", or
> Stories in the backlog to fix the identified issues (with JIRA tickets)
> and problem tests ignored
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
