[
https://issues.apache.org/jira/browse/GEODE-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278363#comment-17278363
]
ASF GitHub Bot commented on GEODE-8916:
---------------------------------------
boglesby opened a new pull request #6001:
URL: https://github.com/apache/geode/pull/6001
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The gfsh export stack traces command should include the locators
> ----------------------------------------------------------------
>
> Key: GEODE-8916
> URL: https://issues.apache.org/jira/browse/GEODE-8916
> Project: Geode
> Issue Type: Bug
> Components: docs
> Reporter: Barrett Oglesby
> Priority: Major
>
> The gfsh export stack traces command should include the locators, but only
> includes the servers.
> Here is an excerpt from a slack conversation showing the behavior:
> {noformat}
> Shelley Hughes-Godfrey 6:48 PM
> I have a question about gfsh export stack-traces ...
> "list members" shows me servers and locators ...
> gfsh>list members
> Member Count : 3
> Name | Id
> ------------------------- |
> ----------------------------------------------------------------------------
> gemfire-cluster-server-0 | xx.xx.x.xxx(gemfire-cluster-server-0:1)<v1>:41000
> gemfire-cluster-locator-0 |
> xx.xx.x.xxx(gemfire-cluster-locator-0:1:locator)<ec><v0>:41000 [Coordinator]
> gemfire-cluster-server-1 | xx.xx.x.xxx(gemfire-cluster-server-1:1)<v2>:41000
> But, if I don't specify members on the export stack-traces command, I just
> get the stacks for the servers.
> gfsh>export stack-traces
> stack-trace(s) exported to file: /path/stacktrace_1612316330340
> On host : ...
> Specifying a locator returns "No Members found"
> gfsh>export stack-traces --member=gemfire-cluster-locator-0
> No Members Found
> Barry Oglesby 2 hours ago
> That command excludes the locators. It uses this method in ManagementUtils to
> get just the normal members:
> public static Set<DistributedMember> getAllNormalMembers(InternalCache cache)
> {
> return new HashSet<DistributedMember>(
> cache.getDistributionManager().getNormalDistributionManagerIds());
> }
> Shelley Hughes-Godfrey 1 hour ago
> So, I also ran "export logs" with --member=<locator>
> And that works
> gfsh>list members
> Member Count : 3
> Name | Id
> ------------------------- |
> ----------------------------------------------------------------------------
> gemfire-cluster-server-0 | xx.xx.x.xxx(gemfire-cluster-server-0:1)<v2>:41000
> gemfire-cluster-locator-0 |
> xx.xx.x.xxx(gemfire-cluster-locator-0:1:locator)<ec><v0>:41000 [Coordinator]
> gemfire-cluster-server-1 | xx.xx.x.xxx(gemfire-cluster-server-1:1)<v1>:41000
> gfsh>export logs --member=gemfire-cluster-locator-0
> Logs exported to the connected member's file system:
> /path/exportedLogs_1612374651595.zip
> Barry Oglesby 44 minutes ago
> The ExportLogsCommand gets all the members including the locators:
> Set<DistributedMember> targetMembers = getMembersIncludingLocators(groups,
> memberIds);
> I tried a test by changing ExportStackTraceCommand.exportStackTrace:
> From:
> Set<DistributedMember> targetMembers = getMembers(group, memberNameOrId);
> To:
> Set<DistributedMember> targetMembers = getMembersIncludingLocators(group,
> memberNameOrId);
> And the locator stack was exported:
> *** Stack-trace for member locator at 2021/02/03 10:01:28.824 ***
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
