[
https://issues.apache.org/jira/browse/GEODE-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283276#comment-17283276
]
ASF GitHub Bot commented on GEODE-8936:
---------------------------------------
nonbinaryprogrammer commented on pull request #6025:
URL: https://github.com/apache/geode/pull/6025#issuecomment-777691542
> Something else to think about is that we changed `INCRBYFLOAT` to parse a
BigDecimal rather than a long. I'm not sure if we want to change all INCR/DECR
related commands to parse BigIntegers or BigDecimals? (If we did, then we
wouldn't have to worry about the max/min 64 bit signed integer value tests...
it would be different from Redis, but we are already different due to the
change in `INCRBYFLOAT`)
>
> **Update:** Jens told me BigDecimals were used in `INCRBYFLOAT` so that
floating point would be more accurate... and keeping long for other INCR/DECR
ops will be faster performance-wise. So unless we think there's a strong use
case (maybe page view count?) or selling point for being able to INCR/DECR
larger values than Redis, maybe that change doesn't make sense.
I think that in this case we should favor performance over consistency with
another command, especially since that command isn't consistent with native
redis. thank you for looking into that though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Redis: **INCR** command supported
> ---------------------------------
>
> Key: GEODE-8936
> URL: https://issues.apache.org/jira/browse/GEODE-8936
> Project: Geode
> Issue Type: Test
> Components: redis
> Reporter: Hale Bales
> Assignee: Hale Bales
> Priority: Major
> Labels: pull-request-available
>
> Write unit/integration tests that run against both Geode Redis and native
> Redis, and dunit tests which test multiple concurrent clients accessing
> different servers for the following command:
> INCR
> A.C.
> Unit/integration tests for both Geode and native Redis passing
> DUNIT tests passing
> README/redis_api_for_geode.html.md.erb updated to make command "supported"
> or
> Stories in the backlog to fix the identified issues (with JIRA tickets)
> and problem tests ignoredMGET
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
