[
https://issues.apache.org/jira/browse/GEODE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285641#comment-17285641
]
ASF GitHub Bot commented on GEODE-8905:
---------------------------------------
rhoughton-pivot commented on a change in pull request #5989:
URL: https://github.com/apache/geode/pull/5989#discussion_r577341266
##########
File path:
buildSrc/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy
##########
@@ -172,17 +179,12 @@ class DependencyConstraints implements Plugin<Project> {
}
}
- dependencySet(group: 'com.fasterxml.jackson.core', version: '2.12.1') {
+ dependencySet(group: 'com.fasterxml.jackson.core', version:
get('jackson.version')) {
entry('jackson-annotations')
entry('jackson-core')
entry('jackson-databind')
}
- dependencySet(group: 'com.fasterxml.jackson.datatype', version: '2.12.1') {
- entry('jackson-datatype-joda')
Review comment:
Is there something about the other form of this declaration that we like
better?
##########
File path:
buildSrc/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy
##########
@@ -87,6 +91,8 @@ class DependencyConstraints implements Plugin<Project> {
api(group: 'cglib', name: 'cglib', version: get('cglib.version'))
api(group: 'com.arakelian', name: 'java-jq', version: '1.1.0')
api(group: 'com.carrotsearch.randomizedtesting', name:
'randomizedtesting-runner', version: '2.7.8')
+ api(group: 'com.fasterxml.jackson.datatype', name:
'jackson-datatype-joda', version: get('jackson.version'))
Review comment:
These had been declared as part of a `dependencySet` on about line 181.
Why did they move?
##########
File path: extensions/geode-modules-session/build.gradle
##########
@@ -29,6 +29,7 @@ dependencies {
exclude module: 'geode-modules'
}
compile(project(':geode-core'))
+ compile(project(':geode-common'))
Review comment:
Lets prefer moving to `implementation` for all new dependencies we add,
instead of propagating deprecated configuration types
##########
File path: geode-core/build.gradle
##########
@@ -311,7 +313,7 @@ dependencies {
implementation('com.healthmarketscience.rmiio:rmiio')
//Geode-common has annotations and other pieces used geode-core
- api(project(':geode-common'))
+ implementation(project(':geode-common'))
Review comment:
This needs to be `api`. `geode-common` declares `Identifiable`, which is
implemented by `CacheElement` in `geode-core`. There are other examples.
##########
File path: geode-jboss-extensions/build.gradle
##########
@@ -0,0 +1,28 @@
+import org.apache.geode.gradle.plugins.DependencyConstraints
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply from: "${rootDir}/${scriptDir}/standard-subproject-configuration.gradle"
+
+apply from: "${project.projectDir}/../gradle/publish-java.gradle"
+
+
+dependencies {
+ implementation(platform(project(':boms:geode-all-bom')))
+ compileOnly('org.jboss.modules:jboss-modules:' +
DependencyConstraints.get("jboss-modules.version"))
Review comment:
Changing the platform dependency from `implementation` to `compileOnly`
will let you remove the `DependencyConstraints.get()` from line 27.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Introduce JarDeploymentService
> ------------------------------
>
> Key: GEODE-8905
> URL: https://issues.apache.org/jira/browse/GEODE-8905
> Project: Geode
> Issue Type: Improvement
> Components: gfsh, management
> Reporter: Patrick Johnsn
> Priority: Major
>
> Introduce a JarDeploymentService interface that will allow us to interchange
> the current way of deploying jars with the new modular approach.
>
> There will be an implementation that delegates to the existing JarDeployer
> and will maintain current behavior.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
