[
https://issues.apache.org/jira/browse/GEODE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287364#comment-17287364
]
ASF GitHub Bot commented on GEODE-8905:
---------------------------------------
bschuchardt commented on a change in pull request #5989:
URL: https://github.com/apache/geode/pull/5989#discussion_r579469077
##########
File path:
geode-core/src/integrationTest/java/org/apache/geode/internal/ClassPathLoaderDeployTest.java
##########
@@ -129,15 +133,17 @@ public void deployNewVersionOfFunctionOverOldVersion()
throws Exception {
GemFireCache gemFireCache = server.getCache();
DistributedSystem distributedSystem = gemFireCache.getDistributedSystem();
- ClassPathLoader.getLatest().getJarDeployer().deploy(jarVersion1);
+ JarDeploymentServiceFactory.getJarDeploymentServiceInstance()
+ .deploy(createDeploymentFromJar(jarVersion1));
assertThatClassCanBeLoaded("jddunit.function.MyFunction");
Execution execution =
FunctionService.onMember(distributedSystem.getDistributedMember());
List<String> result = (List<String>)
execution.execute("MyFunction").getResult();
assertThat(result.get(0)).isEqualTo("Version1");
- ClassPathLoader.getLatest().getJarDeployer().deploy(jarVersion2);
+ JarDeploymentServiceFactory.getJarDeploymentServiceInstance()
Review comment:
We would like to move everything in org.apache.geode.internal into more
specific packages that are pertinent to their function. Please move
ClassPathLoader and associated tests to a different package as part of this PR.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
##########
@@ -94,26 +92,16 @@ public void
deployJarsReceivedFromClusterConfiguration(ConfigurationResponse res
.flatMap(Set::stream)
.collect(Collectors.toList());
- if (jarFileNames != null && !jarFileNames.isEmpty()) {
+ if (!jarFileNames.isEmpty()) {
logger.info("Got response with jars: {}",
jarFileNames.stream().collect(joining(",")));
- JarDeployer jarDeployer = ClassPathLoader.getLatest().getJarDeployer();
- jarDeployer.suspendAll();
- try {
- Set<File> stagedJarFiles =
- getJarsFromLocator(response.getMember(), response.getJarNames());
-
- for (File stagedJarFile : stagedJarFiles) {
- logger.info("Removing old versions of {} in cluster configuration.",
Review comment:
Some Info-level log statements have been lost here. Why are they no
longer needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Introduce JarDeploymentService
> ------------------------------
>
> Key: GEODE-8905
> URL: https://issues.apache.org/jira/browse/GEODE-8905
> Project: Geode
> Issue Type: Improvement
> Components: gfsh, management
> Reporter: Patrick Johnsn
> Priority: Major
> Labels: pull-request-available
>
> Introduce a JarDeploymentService interface that will allow us to interchange
> the current way of deploying jars with the new modular approach.
>
> There will be an implementation that delegates to the existing JarDeployer
> and will maintain current behavior.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
