[
https://issues.apache.org/jira/browse/GEODE-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289982#comment-17289982
]
ASF GitHub Bot commented on GEODE-8864:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5954:
URL: https://github.com/apache/geode/pull/5954#discussion_r582033438
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/data/RedisHash.java
##########
@@ -46,19 +53,91 @@
public class RedisHash extends AbstractRedisData {
public static final RedisHash NULL_REDIS_HASH = new NullRedisHash();
private HashMap<ByteArrayWrapper, ByteArrayWrapper> hash;
+ private ConcurrentHashMap<UUID, List<ByteArrayWrapper>> hScanSnapShots;
+ private ConcurrentHashMap<UUID, Long> hScanSnapShotCreationTimes;
+ private ScheduledExecutorService HSCANSnapshotExpirationExecutor = null;
+
+ private static int default_hscan_snapshots_expire_check_frequency =
+ Integer.parseInt(
+
System.getProperty("HSCAN_SNAPSHOTS_EXPIRE_CHECK_FREQUENCY_MILLISECONDS",
+ "30000"));
+
+ private static int default_hscan_snapshots_milliseconds_to_live =
+ Integer.parseInt(
+
System.getProperty("HSCAN_SNAPSHOTS_EXPIRE_CHECK_FREQUENCY_MILLISECONDS",
+ "30000"));
+
Review comment:
Integer already has some shortcuts to parse system properties. I'd also
suggest the properties be something like `redis.hscan-snapshot-expiry` and
`redis.hscan-snapshot-cleanup-interval`. Retrieving them then becomes:
`Integer.getInteger("redis.hscan-snapshot-expiry", 30000)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> finish implementation of Redis HScan Command
> --------------------------------------------
>
> Key: GEODE-8864
> URL: https://issues.apache.org/jira/browse/GEODE-8864
> Project: Geode
> Issue Type: New Feature
> Components: redis
> Reporter: John Hutchison
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
