[
https://issues.apache.org/jira/browse/GEODE-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291101#comment-17291101
]
ASF GitHub Bot commented on GEODE-8956:
---------------------------------------
mivanac commented on a change in pull request #6048:
URL: https://github.com/apache/geode/pull/6048#discussion_r583051737
##########
File path:
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
##########
@@ -170,6 +207,28 @@ private synchronized Object
updateAllLocatorInfo(RemoteLocatorJoinRequest reques
return new RemoteLocatorJoinResponse(this.getAllLocatorsInfo());
}
+ private ExecutorService createThreadPool() {
Review comment:
As current implementation, start() method, is only invoked from
InternalLocator constructor. If we are concerned about future use, I can make
corrections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> LocatorMembershipListenerImpl has unconstrained thread creation that can
> crash a machine
> ----------------------------------------------------------------------------------------
>
> Key: GEODE-8956
> URL: https://issues.apache.org/jira/browse/GEODE-8956
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Bruce J Schuchardt
> Assignee: Mario Ivanac
> Priority: Major
> Labels: pull-request-available
>
> In reviewing PR 6013 I found that a simple change meant to resolve a
> difficult problem lead to unrestrained thread growth, sometimes topping out
> at over 5000 threads, in a locator that often crashed the host machine. The
> thread growth was due to this method in LocatorMembershipListenerImpl:
> {code:java}
> Thread buildLocatorsDistributorThread(DistributionLocatorId localLocatorId,
> Map<Integer, Set<DistributionLocatorId>> remoteLocators,
> DistributionLocatorId joiningLocator,
> int joiningLocatorDistributedSystemId) {
> Runnable distributeLocatorsRunnable =
> new DistributeLocatorsRunnable(config.getMemberTimeout(), tcpClient,
> localLocatorId,
> remoteLocators, joiningLocator, joiningLocatorDistributedSystemId);
> ThreadFactory threadFactory = new
> LoggingThreadFactory(LOCATORS_DISTRIBUTOR_THREAD_NAME, true);
> return threadFactory.newThread(distributeLocatorsRunnable);
> }
> {code}
> This should probably be performed in an Executor with a reasonable
> max-threads limit based on the number of local and remote-locators in the
> DistributionConfig.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
