[
https://issues.apache.org/jira/browse/GEODE-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291272#comment-17291272
]
ASF GitHub Bot commented on GEODE-8864:
---------------------------------------
jhutchison commented on a change in pull request #5954:
URL: https://github.com/apache/geode/pull/5954#discussion_r583251783
##########
File path:
geode-redis/src/commonTest/java/org/apache/geode/redis/ConcurrentLoopingThreads.java
##########
@@ -63,13 +65,19 @@ private ConcurrentLoopingThreads start(boolean lockstep) {
* operations.
*/
public void await() {
- loopingFutures.forEach(loopingThread -> {
- try {
- loopingThread.get();
- } catch (InterruptedException | ExecutionException e) {
- throw new RuntimeException(e);
+ boolean timeOutExceptionThrown;
+ do {
+ timeOutExceptionThrown = false;
Review comment:
it does have a time out- the get on line 73 passes in a 1 second
timeout, which allows the get to throw a time out exception. This is being
caught to allow for retry logic. Let me know if something still doesn't seem
right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> finish implementation of Redis HScan Command
> --------------------------------------------
>
> Key: GEODE-8864
> URL: https://issues.apache.org/jira/browse/GEODE-8864
> Project: Geode
> Issue Type: New Feature
> Components: redis
> Reporter: John Hutchison
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
