[
https://issues.apache.org/jira/browse/GEODE-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299091#comment-17299091
]
ASF GitHub Bot commented on GEODE-9018:
---------------------------------------
DonalEvans commented on a change in pull request #6110:
URL: https://github.com/apache/geode/pull/6110#discussion_r591804577
##########
File path:
geode-core/src/integrationTest/java/org/apache/geode/cache/query/internal/index/CompactRangeIndexJUnitTest.java
##########
@@ -442,6 +445,48 @@ public void doTestHook(final SPOTS spot, final
DefaultQuery _ignored,
}
}
+ /**
+ * Tests adding entries to compact range index where there are undefined and
null values
+ * for the key
+ */
+ @Test
+ public void testNullAndUndefinedValuesForMapKeyInCompactRangeIndex() throws
Exception {
Review comment:
Would it be possible to write a test that wasn't flaky when it failed?
If something changed in future that made this test fail, it would be best if it
failed immediately rather than randomly some time after the breaking change was
made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ExtendedNumericComparator does not compare correctly NULL and UNDEFINED
> -----------------------------------------------------------------------
>
> Key: GEODE-9018
> URL: https://issues.apache.org/jira/browse/GEODE-9018
> Project: Geode
> Issue Type: Bug
> Components: querying
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
>
> The compareTo method of ExtendedNumericComparator does not compare correctly
> UNDEFINED and NULL.
> UNDEFINED should always be smaller than anything but it is not always so when
> compared with NULL.
> compareTo(NULL, UNDEFINED) returns 1, which is correct
> but
> compareTo(UNDEFINED, NULL) returns 1, and it should return -1.
> This could provoke that queries with indexes do not return the right results
> when these values are involved.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
