[
https://issues.apache.org/jira/browse/GEODE-4601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ernest Burghardt updated GEODE-4601:
------------------------------------
Issue Type: Improvement (was: Task)
> Refactor TcrMessage - resolve accessor encapsulation
> ----------------------------------------------------
>
> Key: GEODE-4601
> URL: https://issues.apache.org/jira/browse/GEODE-4601
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Addison
> Priority: Major
>
> {{TcrMessage}} has accessor {{setMessageType()}} which should be removed from
> the base class. It is used only on reply messages, _not_ request messages.
> Here are some steps we can take:
> # Move it into the {{TcrMessageReply}} class.
> # Remove the accessor entirely by altering internal APIs, e.g.
> {{TcrMessageHelper::readChunkPartHeader()}}, to return a message object
> rather than taking a reference to a message and then modifying the type.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
