[
https://issues.apache.org/jira/browse/GEODE-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334970#comment-17334970
]
ASF GitHub Bot commented on GEODE-9200:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #793:
URL: https://github.com/apache/geode-native/pull/793#discussion_r622488201
##########
File path: cppcache/src/ThinClientPoolHADM.cpp
##########
@@ -292,11 +293,11 @@ void
ThinClientPoolHADM::removeCallbackConnection(TcrEndpoint* ep) {
m_redundancyManager->removeCallbackConnection(ep);
}
-void ThinClientPoolHADM::sendNotConMesToAllregions() {
+void ThinClientPoolHADM::sendNotConnectedMessageToAllRegions() {
std::lock_guard<decltype(m_regionsLock)> guard(m_regionsLock);
for (std::list<ThinClientRegion*>::iterator it = m_regions.begin();
Review comment:
Can this be changed to a for range loop?
##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -2967,7 +2969,8 @@ void ThinClientRegion::executeFunction(
} else if (err == GF_NOTCON) {
attempt++;
LOGDEBUG(
- "ThinClientRegion::executeFunction with GF_NOTCON retry attempt = "
+ "ThinClientRegion::executeFunction with GF_NOTCON retry attempt "
Review comment:
More odd formatting changes.
##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -2772,7 +2774,7 @@ void ThinClientRegion::receiveNotification(TcrMessage*
msg) {
}
lock.unlock();
- if (TcrMessage::getAllEPDisMess() != msg) _GEODE_SAFE_DELETE(msg);
+ _GEODE_SAFE_DELETE(msg);
Review comment:
Any easy opportunity to make `msg` a smart pointer?
##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -2723,12 +2727,12 @@ GfErrType ThinClientRegion::handleServerException(
"TransactionDataNodeHasDepartedException") !=
std::string::npos) {
error = GF_TRANSACTION_DATA_NODE_HAS_DEPARTED_EXCEPTION;
- } else if (exceptionMsg.find(
- "org.apache.geode.cache.TransactionDataRebalancedException")
!=
+ } else if (exceptionMsg.find("org.apache.geode.cache."
+ "TransactionDataRebalancedException") !=
Review comment:
This feels like an unintentional or at least less readable format change.
##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -3556,9 +3564,9 @@ void ChunkedFunctionExecutionResponse::handleChunk(
return;
}
- auto startLen = static_cast<size_t>(
- input.getBytesRead() -
- 1); // from here need to look value part + memberid AND -1 for array
type
+ auto startLen = static_cast<size_t>(input.getBytesRead() -
+ 1); // from here need to look value part
Review comment:
Move the comment above so the formatting is more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Leaked message used to signal "all endpoints disconnected"
> ----------------------------------------------------------
>
> Key: GEODE-9200
> URL: https://issues.apache.org/jira/browse/GEODE-9200
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Blake Bender
> Assignee: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> Geode native uses a "blank" reply message to signal to regions that all
> endpoints have disconnected, i.e. they can shut down. This message is
> allocated on the heap into a static pointer in the function
> `TcrMessage::getAllEPDisMess`, but is never deleted. This should be a
> dynamically allocated message, so it can be cleaned up via `delete` in the
> region like all other messages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
