[
https://issues.apache.org/jira/browse/GEODE-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369639#comment-17369639
]
ASF GitHub Bot commented on GEODE-9401:
---------------------------------------
mmartell commented on a change in pull request #825:
URL: https://github.com/apache/geode-native/pull/825#discussion_r658948330
##########
File path: clicache/src/impl/PdxFieldType.cpp
##########
@@ -166,23 +166,23 @@ namespace Apache
switch (m_typeId)
{
case PdxFieldTypes::BYTE:
- return PdxTypes::BYTE_SIZE;
+ return PdxTypes::PDX_BYTE_SIZE;
Review comment:
Done. Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix Duplicate Defines on OSX
> ----------------------------
>
> Key: GEODE-9401
> URL: https://issues.apache.org/jira/browse/GEODE-9401
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> Recent changes to system headers causes compile errors on OSX due to
> redefinition of:
> * BYTE_SIZE
> * PAGE_SIZE
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
