Eric Shu created GEODE-9404:
-------------------------------
Summary: Should not log "No information for senderId: " if the
node processing the tx does not have sender configured
Key: GEODE-9404
URL: https://issues.apache.org/jira/browse/GEODE-9404
Project: Geode
Issue Type: Bug
Components: transactions
Reporter: Eric Shu
In serial wan setting, not all nodes have the sender configured. These error
logging should not be logged. But currently it is logged for every tx operation
if the the node does not have sender configured (which is a normal case for
serail wan).
The following stack shows where it was logged.
org.apache.geode.internal.cache.TXLastEventInTransactionUtils.checkNoSendersGroupTransactionEvents(TXLastEventInTransactionUtils.java:81)
at
org.apache.geode.internal.cache.TXLastEventInTransactionUtils.getLastTransactionEvent(TXLastEventInTransactionUtils.java:45)
at
org.apache.geode.internal.cache.TXState.firePendingCallbacks(TXState.java:250)
at org.apache.geode.internal.cache.TXState.commit(TXState.java:544)
at
org.apache.geode.internal.cache.TXStateProxyImpl.commit(TXStateProxyImpl.java:237)
at org.apache.geode.internal.cache.TXManagerImpl.commit(TXManagerImpl.java:444)
{code:java}
private static boolean
checkNoSendersGroupTransactionEvents(List<EntryEventImpl> callbacks,
Cache cache) throws ServiceConfigurationError {
for (String senderId : getSenderIdsForEvents(callbacks)) {
GatewaySender sender = cache.getGatewaySender(senderId);
if (sender == null) {
logger.error("No sender found for {}", senderId, new Exception());
throw new ServiceConfigurationError("No information for senderId: " +
senderId);
}
if (sender.mustGroupTransactionEvents()) {
return false;
}
}
return true;
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
