[
https://issues.apache.org/jira/browse/GEODE-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372187#comment-17372187
]
ASF GitHub Bot commented on GEODE-9405:
---------------------------------------
mmartell commented on pull request #826:
URL: https://github.com/apache/geode-native/pull/826#issuecomment-871690085
Converting to Draft for now. All but one of the files that fail to compile
on rhel-8 due to strncpy warnings are disabled tests that use a bogus
getXmlPath() function. This function not only uses an unsafe strncpy(), but
uses an incorrect path to the Xml folder. Looks like this is an artifact of
moving the Xml folder in native client 10, but not fixing up all the tests to
use the new path.
Rather than just fix the compile problem for tests that we never run, I
think it is worth investigating whether we can reenable all these tests by
using the correct path. Of course we will also fix the compile problem that's
causing the build failure on rhel-8.
The list of tests that experience this issue includes:
testThinClientSecurityAuthentication.cpp (broken)
testThinClientSecurityAuthenticationSetAuthInitialize.cpp
testThinClientSecurityAuthorization.cpp (broken)
testThinClientSecurityAuthorizationMU.cpp (broken)
testThinClientSecurityCQAuthorizationMU.cpp (flaky)
testThinClientSecurityDurableCQAuthorizationMU.cpp (broken)
testThinClientWriterException.cpp (broken)
ThinClientSecurityHelper.hpp (not a test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build fails on rhel-8 release
> -----------------------------
>
> Key: GEODE-9405
> URL: https://issues.apache.org/jira/browse/GEODE-9405
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> Looks like a recent gcc compiler change on rhel-8 is causing build failures
> in the CI.
> Looks to be related to unsafe use of strncpy in a few of our legacy C++ tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
