[
https://issues.apache.org/jira/browse/GEODE-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alberto Gomez resolved GEODE-9421.
----------------------------------
Fix Version/s: 1.15.0
Resolution: Fixed
ParallelAsyncEventQueueImplTest and ParallelGatewaySenderImplTest classes were
mocking InternalRegion
but were not providing an implementation for cache.getCancelCriterion().
This led to a null pointer exception in the BatchRemoval thread code that,
even though it did not affect the tests, provoked that a log message with
a null pointer exception was printed.
The solution consists of adding a response in the mock using when() for the
cache.getCancelCriterion() method.
> Remove ParallelGatewaySenderQueue$BatchRemovalThread NPE logs when running
> JUnit tests
> --------------------------------------------------------------------------------------
>
> Key: GEODE-9421
> URL: https://issues.apache.org/jira/browse/GEODE-9421
> Project: Geode
> Issue Type: Improvement
> Components: tests
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> The ouput of the run of the CI sometimes shows the following NPE logs:
> Exception in thread "BatchRemovalThread for GatewaySender_sender_0"
> java.lang.NullPointerException
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue$BatchRemovalThread.checkCancelled(ParallelGatewaySenderQueue.java:1841)
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue$BatchRemovalThread.run(ParallelGatewaySenderQueue.java:1942)
> Exception in thread "BatchRemovalThread for GatewaySender_sender_4"
> java.lang.NullPointerException
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue$BatchRemovalThread.checkCancelled(ParallelGatewaySenderQueue.java:1841)
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue$BatchRemovalThread.run(ParallelGatewaySenderQueue.java:1942)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
