[
https://issues.apache.org/jira/browse/GEODE-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399893#comment-17399893
]
ASF GitHub Bot commented on GEODE-9501:
---------------------------------------
pdxcodemonkey commented on a change in pull request #841:
URL: https://github.com/apache/geode-native/pull/841#discussion_r689741407
##########
File path: ci/base/base.yml
##########
@@ -61,7 +61,7 @@ builds:
with_dot_net: #@ True
#@yaml/map-key-override
params:
- CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv141,version=14.16,host=x64
-DCMAKE_SYSTEM_VERSION=10.0.16299.0"
Review comment:
Okay, so some Googling tells me that for cmake 3.13 or newer, we need to
ditch "Win64" in the -G parameter and use "-A x64" to configure 64-bit builds:
https://stackoverflow.com/questions/28350214/how-to-build-x86-and-or-x64-on-windows-from-command-line-with-cmake
And "-T host=x64" is used only to specifically force 64-bit toolset, so I
don't suppose this is anything other than maybe a small performance hit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Support Latest Microsoft Platform Toolset and Compilers for C++
> ---------------------------------------------------------------
>
> Key: GEODE-9501
> URL: https://issues.apache.org/jira/browse/GEODE-9501
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Michael Martell
> Priority: Major
>
> Currently, the Windows build of geode-native uses Platform Toolset v141. This
> ticket is to build using the default Platform Toolset and compiler which is
> v142.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
