[
https://issues.apache.org/jira/browse/GEODE-9595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-9595:
-----------------------------
Description:
I found circular dependencies that cause failures in new tests in geode-core,
geode-cq, geode-gfsh, geode-management, geode-wan, geode-web-api.
The circular dependencies result in the module such as geode-core adding
geode-core*.jar to the classpath of the tests. Classes and resources are then
loaded into the test JVM from the .jar file instead of from the filesystem.
This causes issues only in some tests such as AnalyzeSerializables integration
tests.
To reproduce:
1) Delete any line from
geode-core/src/main/resources/org/apache/geode/internal/sanctioned-geode-core-serializables.txt
2) Execute {{$ ./gradlew geode-core:integrationTest --tests
AnalyzeCoreSerializablesIntegrationTest}}
{{testSerializables}} will fail with {{FileSystemNotFoundException}}:
{noformat}
org.apache.geode.codeAnalysis.AnalyzeCoreSerializablesIntegrationTest >
testSerializables FAILED
java.nio.file.FileSystemNotFoundException
at
com.sun.nio.zipfs.ZipFileSystemProvider.getFileSystem(ZipFileSystemProvider.java:171)
at
com.sun.nio.zipfs.ZipFileSystemProvider.getPath(ZipFileSystemProvider.java:157)
at java.nio.file.Paths.get(Paths.java:143)
at
org.apache.geode.codeAnalysis.AnalyzeDataSerializablesJUnitTestBase.mainResourceToSourcePath(AnalyzeDataSerializablesJUnitTestBase.java:260)
at
org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTestBase.testSerializables(AnalyzeSerializablesJUnitTestBase.java:102)
{noformat}
was:
I found circular dependencies that cause failures in new tests in geode-core,
geode-cq, geode-gfsh, geode-management, geode-wan, geode-web-api.
The circular dependencies result in the module such as geode-core adding
geode-core*.jar to the classpath of the tests. Classes and resources are then
loaded into the test JVM from the .jar file instead of from the filesystem.
This causes issues only in some tests such as AnalyzeSerializables integration
tests.
To reproduce:
1) Delete any line from
geode-core/src/main/resources/org/apache/geode/internal/sanctioned-geode-core-serializables.txt
2) Execute $ ./gradlew geode-core:integrationTest --tests
AnalyzeCoreSerializablesIntegrationTest
> Analyze serializables testSerializables fails with FileSystemNotFoundException
> ------------------------------------------------------------------------------
>
> Key: GEODE-9595
> URL: https://issues.apache.org/jira/browse/GEODE-9595
> Project: Geode
> Issue Type: Bug
> Components: build
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
> Labels: pull-request-available
>
> I found circular dependencies that cause failures in new tests in geode-core,
> geode-cq, geode-gfsh, geode-management, geode-wan, geode-web-api.
> The circular dependencies result in the module such as geode-core adding
> geode-core*.jar to the classpath of the tests. Classes and resources are then
> loaded into the test JVM from the .jar file instead of from the filesystem.
> This causes issues only in some tests such as AnalyzeSerializables
> integration tests.
> To reproduce:
> 1) Delete any line from
> geode-core/src/main/resources/org/apache/geode/internal/sanctioned-geode-core-serializables.txt
> 2) Execute {{$ ./gradlew geode-core:integrationTest --tests
> AnalyzeCoreSerializablesIntegrationTest}}
> {{testSerializables}} will fail with {{FileSystemNotFoundException}}:
> {noformat}
> org.apache.geode.codeAnalysis.AnalyzeCoreSerializablesIntegrationTest >
> testSerializables FAILED
> java.nio.file.FileSystemNotFoundException
> at
> com.sun.nio.zipfs.ZipFileSystemProvider.getFileSystem(ZipFileSystemProvider.java:171)
> at
> com.sun.nio.zipfs.ZipFileSystemProvider.getPath(ZipFileSystemProvider.java:157)
> at java.nio.file.Paths.get(Paths.java:143)
> at
> org.apache.geode.codeAnalysis.AnalyzeDataSerializablesJUnitTestBase.mainResourceToSourcePath(AnalyzeDataSerializablesJUnitTestBase.java:260)
> at
> org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTestBase.testSerializables(AnalyzeSerializablesJUnitTestBase.java:102)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
