[
https://issues.apache.org/jira/browse/GEODE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422802#comment-17422802
]
ASF GitHub Bot commented on GEODE-9576:
---------------------------------------
alb3rtobr commented on a change in pull request #864:
URL: https://github.com/apache/geode-native/pull/864#discussion_r719434065
##########
File path: cppcache/integration/test/FunctionExecutionTest.cpp
##########
@@ -175,6 +196,88 @@ TEST(FunctionExecutionTest,
cache.close();
}
+void populateRegion(const std::shared_ptr<Region> ®ion) {
+ for (int i = 0; i < PARTITION_REGION_ENTRIES_SIZE; i++) {
+ region->put("KEY--" + std::to_string(i), "VALUE--" + std::to_string(i));
+ }
+}
+
+void waitUntilPRMetadataIsRefreshed(CacheImpl *cacheImpl) {
+ auto end = std::chrono::system_clock::now() + std::chrono::minutes(2);
+ while (!cacheImpl->getAndResetPrMetadataUpdatedFlag()) {
+ std::this_thread::sleep_for(std::chrono::milliseconds(200));
+ ASSERT_FALSE(std::chrono::system_clock::now() > end);
+ }
+}
+
+TEST(FunctionExecutionTest, FunctionExecutionWithIncompleteBucketLocations) {
+ std::vector<uint16_t> serverPorts;
+ serverPorts.push_back(Framework::getAvailablePort());
+ serverPorts.push_back(Framework::getAvailablePort());
+ serverPorts.push_back(Framework::getAvailablePort());
+ Cluster cluster{LocatorCount{1}, ServerCount{3}, serverPorts};
+
+ cluster.start([&]() {
+ cluster.getGfsh()
+ .deploy()
+ .jar(getFrameworkString(FrameworkVariable::JavaObjectJarPath))
+ .execute();
+ });
+
+ cluster.getGfsh()
+ .create()
+ .region()
+ .withName("partition_region")
+ .withType("PARTITION")
+ .execute();
+
+ auto cache = CacheFactory().create();
+ auto poolFactory = cache.getPoolManager().createFactory();
+
+ ServerAddress serverAddress = cluster.getServers()[2].getAddress();
+ cluster.applyServer(poolFactory, serverAddress);
+
+ auto pool =
+ poolFactory.setPRSingleHopEnabled(true).setRetryAttempts(0).create(
+ "pool");
+
+ auto region = cache.createRegionFactory(RegionShortcut::PROXY)
+ .setPoolName("pool")
+ .create("partition_region");
+
+ // Populate region in a way that not all buckets are created.
+ // Servers in this case will create 88 of possible 113 buckets.
+ populateRegion(region);
+
+ // Check that PR metadata is updated. This is done to be sure
+ // that client will execute function in a non single hop manner
+ // because metadata doesn't contain all bucket locations.
+ // After metadata is refreshed, it will contain at least one
+ // bucket location.
+ CacheImpl *cacheImpl = CacheRegionHelper::getCacheImpl(&cache);
+ waitUntilPRMetadataIsRefreshed(cacheImpl);
+
+ auto functionService = FunctionService::onRegion(region);
+ auto rc =
+ functionService.withCollector(std::make_shared<TestResultCollector>())
+ .execute("MultiGetAllFunctionNonHA");
+
+ std::shared_ptr<TestResultCollector> resultCollector =
+ std::dynamic_pointer_cast<TestResultCollector>(rc);
+
+ // check that function is not re-executed
+ ASSERT_FALSE(resultCollector->isClearTriggered());
+
+ // check that PR metadata is updated after function is executed
+ waitUntilPRMetadataIsRefreshed(cacheImpl);
+
+ // check that correct nubmer of events is received in function result
Review comment:
There is a typo here (`nubmer`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> InternalFunctionInvocationTargetException when executing single hop function
> all buckets
> ----------------------------------------------------------------------------------------
>
> Key: GEODE-9576
> URL: https://issues.apache.org/jira/browse/GEODE-9576
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Jakov Varenina
> Assignee: Jakov Varenina
> Priority: Major
> Labels: pull-request-available
>
> *InternalFunctionInvocationTargetException: Multiple target nodes found for
> single hop operation* occurs on native client when executing function in a
> single hop manner for all buckets during the period when client bucket
> metadata doesn't contain all buckets locations.
> Java client in this case executes functions in non single hop manner until it
> receives locations of all buckets on servers. The solution in native client
> would be to implement the same handling as in java client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
