[
https://issues.apache.org/jira/browse/GEODE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436863#comment-17436863
]
ASF GitHub Bot commented on GEODE-9741:
---------------------------------------
mmartell commented on a change in pull request #888:
URL: https://github.com/apache/geode-native/pull/888#discussion_r740252563
##########
File path: ci/lib/templates.lib.txt
##########
@@ -203,6 +203,9 @@ git_rev=$(git rev-parse HEAD)
popd
version=$(cat version/number)
builddate=$(date "+%Y-%m-%d")
+(@- if use_vcvarsall: @)
+remote_shell "c:/Program Files (x86)\Microsoft Visual
Studio/2019/Community/VC/Auxiliary/Build/vcvarsall.bat" x64 10.0.16299.0
-vcvars_ver=14.20
Review comment:
**Great catch. I**t worked on my local system because it's a single cmd
shell. I took a look at how to do this directly in ACE's CMakeLists.txt, but it
doesn't look like MPC has a value_template for the tools version. Any ideas on
this would be greatly appreciated. Otherwise, can I just pass the vcvarsall.bat
as the first argument to the remote_shell invocation that does the cmake config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Latest Toolchain (v142) to Visual Studio 2019 CI Pipeline
> -------------------------------------------------------------
>
> Key: GEODE-9741
> URL: https://issues.apache.org/jira/browse/GEODE-9741
> Project: Geode
> Issue Type: New Feature
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> Currently the VS 2019 builds use the old toolchain (v141). All tests pass
> with v142, so just requires a small change to CI code, as well as adding the
> v142 tools to the Windows images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
