[
https://issues.apache.org/jira/browse/GEODE-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461553#comment-17461553
]
Jakov Varenina edited comment on GEODE-9903 at 12/17/21, 6:00 PM:
------------------------------------------------------------------
Hi [~dschneider] ,
It seems that this in not just a flaky test case, but it actually hit one
scenario when regionMap for orphaned .drf file is not cleared. From logs it can
be seen that regionMap is not cleared when Oplog is closed early (compaction is
skipped as there are no live entries in Oplog) :
{code:java}
[info 2021/12/15 22:37:18.482 UTC <Idle OplogCompactor> tid=0x71]
Closing
DiskRegionCompactorClearsObjectThatAreNoLongerNeededIntegrationTest_testCompactorRegionMapDeletedForOnlyDrfOplogAfterCompactionIsDone_diskStore
early since it is empty. It is for disk store oplog#6.{code}
You can find the test case and the solution for above scenario in following
draft commit [https://github.com/apache/geode/pull/7208]
Could you please check it and comment?
I will revert the GEODE-9854: and create new PR that incorporates also above
fix.
was (Author: jvarenina):
Hi [~dschneider] ,
It seems that this in not just a flaky test case, but it actually hit one
scenario when regionMap for orphaned .drf file is not cleared. From logs it can
be seen that regionMap is not cleared when Oplog is not compacted (because
there are no live entries), but it is closed early:
{code:java}
[info 2021/12/15 22:37:18.482 UTC <Idle OplogCompactor> tid=0x71]
Closing
DiskRegionCompactorClearsObjectThatAreNoLongerNeededIntegrationTest_testCompactorRegionMapDeletedForOnlyDrfOplogAfterCompactionIsDone_diskStore
early since it is empty. It is for disk store oplog#6.{code}
You can find the test case and the solution for above scenario in following
draft commit [https://github.com/apache/geode/pull/7208]
Could you please check it and comment?
I will revert the GEODE-9854: and create new PR that incorporates also above
fix.
> testCompactorRegionMapDeletedForOnlyDrfOplogAfterCompactionIsDone FAILED
> ------------------------------------------------------------------------
>
> Key: GEODE-9903
> URL: https://issues.apache.org/jira/browse/GEODE-9903
> Project: Geode
> Issue Type: Bug
> Components: persistence
> Affects Versions: 1.15.0
> Reporter: Kristen
> Assignee: Jakov Varenina
> Priority: Major
>
> {{DiskRegionCompactorClearsObjectThatAreNoLongerNeededIntegrationTest >
> testCompactorRegionMapDeletedForOnlyDrfOplogAfterCompactionIsDone FAILED}}
> {{ org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.internal.cache.DiskRegionCompactorClearsObjectThatAreNoLongerNeededIntegrationTest
> }}
> {{ Expecting value to be true but was false within 5 minutes.}}
> {{ at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)}}
> {{ at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)}}
> {{ at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)}}
> {{ at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)}}
> {{ at
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)}}
> {{ at
> org.apache.geode.internal.cache.DiskRegionCompactorClearsObjectThatAreNoLongerNeededIntegrationTest.testCompactorRegionMapDeletedForOnlyDrfOplogAfterCompactionIsDone(DiskRegionCompactorClearsObjectThatAreNoLongerNeededIntegrationTest.java:141)}}{{
> Caused by:}}
> {{ org.opentest4j.AssertionFailedError: }}
> {{ Expecting value to be true but was false}}
> {{ at
> sun.reflect.GeneratedConstructorAccessor22.newInstance(Unknown Source)}}
> {{ at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)}}
> {{ at
> org.apache.geode.internal.cache.DiskRegionCompactorClearsObjectThatAreNoLongerNeededIntegrationTest.lambda$testCompactorRegionMapDeletedForOnlyDrfOplogAfterCompactionIsDone$3(DiskRegionCompactorClearsObjectThatAreNoLongerNeededIntegrationTest.java:142)}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
