[
https://issues.apache.org/jira/browse/GEODE-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478171#comment-17478171
]
ASF GitHub Bot commented on GEODE-9712:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #909:
URL: https://github.com/apache/geode-native/pull/909#discussion_r787112789
##########
File path: c-bindings/include/geode/region.h
##########
@@ -40,18 +40,41 @@ APACHE_GEODE_C_EXPORT void apache_geode_Region_PutString(
apache_geode_region_t* region, const char* key, const char* value);
APACHE_GEODE_C_EXPORT void apache_geode_Region_PutByteArray(
- apache_geode_region_t* region, const char* key, const char* value, size_t
size);
+ apache_geode_region_t* region, const char* key, size_t keyLength,
Review comment:
We should really require length parameters for all array pointers, it's
not safe to rely on `NULL` termination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Genericize All .NET Core Classes
> --------------------------------
>
> Key: GEODE-9712
> URL: https://issues.apache.org/jira/browse/GEODE-9712
> Project: Geode
> Issue Type: New Feature
> Components: native client
> Reporter: Michael Martell
> Assignee: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> We need to implement IRegion<TKey, TValue> in .NET Core. This will require
> writing generic versions of RegionFactory, Region, and Cache.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
