[ https://issues.apache.org/jira/browse/GEODE-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488214#comment-17488214 ]
ASF GitHub Bot commented on GEODE-8679: --------------------------------------- pdxcodemonkey commented on pull request #761: URL: https://github.com/apache/geode-native/pull/761#issuecomment-1031631405 There remains one integration test in the old suite (I believe) that hangs every time when run with DEBUG-level logging and this change. I don't have bandwidth or inclination to debug this issue to resolution. I'm also a lot more reluctant to introduce a 3rd-party logger into our code base, given everyone's recent experience with Log4j issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace Native logger with 3rd party solution > --------------------------------------------- > > Key: GEODE-8679 > URL: https://issues.apache.org/jira/browse/GEODE-8679 > Project: Geode > Issue Type: Improvement > Components: native client > Reporter: Blake Bender > Priority: Major > Labels: pull-request-available > > As a native client developer, I would prefer to only maintain code that > actually implements core features of a Geode client. A logging subsystem is > definitely not core Geode functionality. Additionally, the existing > geode-native logger does not properly support the `loig-file-size-limit` and > `log-disk-space-limit` properties. Rather than attempt to fix the existing > logging code to properly implement these, we should switch to a 3rd-party > solution (spdlog or similar) that already has these features available and > working. -- This message was sent by Atlassian Jira (v8.20.1#820001)