[
https://issues.apache.org/jira/browse/GEODE-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496379#comment-17496379
]
ASF GitHub Bot commented on GEODE-9753:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #891:
URL: https://github.com/apache/geode-native/pull/891#discussion_r812444100
##########
File path: cppcache/src/PdxHelper.cpp
##########
@@ -137,28 +136,18 @@ void PdxHelper::serializePdx(
// so we don't know whether user has used those or not;; Can we do some
// trick here?
- auto createPdxRemoteWriter = [&]() -> PdxRemoteWriter {
- if (auto pd = pdxTypeRegistry->getPreserveData(pdxObject)) {
- auto mergedPdxType =
pdxTypeRegistry->getPdxType(pd->getMergedTypeId());
- return PdxRemoteWriter(output, mergedPdxType, pd, pdxTypeRegistry);
- } else {
- return PdxRemoteWriter(output, className, pdxTypeRegistry);
- }
- };
+ auto prw = cacheImpl->getPdxRemoteWriterFactory().create(
Review comment:
What this extracted into an pure virtual interface for the sole purpose
of integration testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Coredump during PdxSerializable object serialization
> ----------------------------------------------------
>
> Key: GEODE-9753
> URL: https://issues.apache.org/jira/browse/GEODE-9753
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: needsTriage, pull-request-available
>
> *GIVEN* **a single server and locator cluster with 1 PdxSerializable class
> registered, named Order
> *AND* a geode-native client with 1 PdxSerializable 1 PdxSerializable class
> registered, named Order
> *WHEN* a Order object is tried to be serialized
> *WHILE* the cluster is being restarted
> *THEN* a coredump happens due to PdxType=nullptr
> —
> *Additional information*. As seen by early troubleshooting, the coredump
> happens because the pdx type is tried to be fetched from the PdxTypeRegist by
> its class name, but the PdxTypeRegistry is cleaned up during serialization
> given that subscription redundancy was lost.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
