[
https://issues.apache.org/jira/browse/GEODE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497384#comment-17497384
]
ASF GitHub Bot commented on GEODE-10074:
----------------------------------------
pivotal-jbarrett commented on a change in pull request #928:
URL: https://github.com/apache/geode-native/pull/928#discussion_r813859028
##########
File path: cppcache/integration-test/fw_helper.hpp
##########
@@ -107,7 +105,7 @@ BEGIN_TEST.
#define ASSERT_EQ(x, y) _ASSERT_EQ(x, y, __LINE__, __FILE__)
#define ASSERT_STREQ(x, y) \
- ASSERT((strcmp(x, y) == 0), \
+ ASSERT(x == y, \
Review comment:
Yes! So that! One less macro!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove ACE remains
> ------------------
>
> Key: GEODE-10074
> URL: https://issues.apache.org/jira/browse/GEODE-10074
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS A* geode-native contributor
> *I WANT TO* remove all the ACE remaining
> *SO THAT* geode-native does not depend on ACE anymore
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
