[
https://issues.apache.org/jira/browse/GEODE-10139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509106#comment-17509106
]
ASF subversion and git services commented on GEODE-10139:
---------------------------------------------------------
Commit a3d8ef80f0bb1f487ea0dfb7c9de1e7ea82ecf87 in geode's branch
refs/heads/develop from Owen Nichols
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a3d8ef8 ]
GEODE-10139: add -f to curl (#7464)
Without -f, curl will succeed (exitcode 0) even if the response is a 404 error,
etc
This is almost never the desired behavior, especially in scripts that rely on
set -e to fail fast if something goes wrong
> curl should always use -f
> --------------------------
>
> Key: GEODE-10139
> URL: https://issues.apache.org/jira/browse/GEODE-10139
> Project: Geode
> Issue Type: Task
> Components: ci
> Reporter: Owen Nichols
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> curl commands are used throughout our CI and release scripts
> without -f, curl will not fail even when a bad response code such as 404 is
> returned
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
