[ 
https://issues.apache.org/jira/browse/GEODE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517565#comment-17517565
 ] 

ASF subversion and git services commented on GEODE-10126:
---------------------------------------------------------

Commit ee1c412d8af3e6311f569948c3248eddc1fe8009 in geode's branch 
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ee1c412d8a ]

GEODE-10126: Replace Geode for Redis properties with system properties (#7478)

* GEODE-10126: Replace Geode for Redis properties with system properties

- All previous Geode for Redis properties that were defined in
  geode-core are replaced by java system properties.
  - gemfire.geode-for-redis-port
  - gemfire.geode-for-redis-bind-address
  - gemfire.geode-for-redis-bind-username
  - gemfire.geode-for-redis-redundant-copies
  - gemfire.geode-for-redis-enabled
- Redis is enabled (using defaults) if the `enabled` property is set to
  true OR if any of the other properties are explicitly set as java
  system properties.
- Introduce `RedisConfiguration` interface to access properties.
- Concrete implementation of `SystemPropertyBasedRedisConfiguration`
  that uses system properties to define Radish properties.
- Integration Tests use `TestRedisConfiguration` to avoid having to set
  system properties.
- Services started by Geode (`CacheService`s) that throw exceptions
  during initialization will cause the Cache to fail to startup.
  Previously any such errors were only logged.
- Default bind address is explicitly 0.0.0.0 which is more expressive than just 
an empty string

> Refactor Configuration To Use System Properties
> -----------------------------------------------
>
>                 Key: GEODE-10126
>                 URL: https://issues.apache.org/jira/browse/GEODE-10126
>             Project: Geode
>          Issue Type: Improvement
>          Components: redis
>            Reporter: Wayne
>            Priority: Major
>              Labels: pull-request-available
>
> The properties currently being used by the Redis module are defined in Geode 
> core.  These properties need to be removed from Geode core and refactored to 
> system properties.
>  
> Validators must also be added for the system properties to ensure that users 
> provide correct values.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to