[ 
https://issues.apache.org/jira/browse/GEODE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539644#comment-17539644
 ] 

Darrel Schneider commented on GEODE-10287:
------------------------------------------

DistributionAdvisor.close calls operationMonitor.close which sets the "closed" 
field on it to true. So when we call forceNewMembershipVersion it is a noop. 
waitForCurrentOperations is also a noop because operationsAreInProgress will 
now always return false because operationMonitor.close set 
previousVersionOpCount to 0.

> DistributedRegion.distributedRegionCleanup logic looks wrong
> ------------------------------------------------------------
>
>                 Key: GEODE-10287
>                 URL: https://issues.apache.org/jira/browse/GEODE-10287
>             Project: Geode
>          Issue Type: Bug
>          Components: core
>            Reporter: Darrel Schneider
>            Assignee: Jinmei Liao
>            Priority: Major
>
> DistributedRegion.distributedRegionCleanup does this: distAdvisor.close(). 
> Then a few lines later it calls "waitForCurrentOperations()". But 
> waitForCurrentOperations uses the closed distAdvisor. Maybe it is okay to 
> uses a closed distAdvisor but it seems better to call wait first and then 
> close distAdvisor.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to